Migrating ENDF interfacing from endf_parserpy to openmc.data - #310
Open
eitan-weinstein wants to merge 8 commits into
Open
Migrating ENDF interfacing from endf_parserpy to openmc.data#310eitan-weinstein wants to merge 8 commits into
endf_parserpy to openmc.data#310eitan-weinstein wants to merge 8 commits into
Conversation
eitan-weinstein
added this to the
Complete pipeline for the inclusion of new data libraries milestone
eitan-weinstein
force-pushed
the
openmc_migration
branch
from
July 30, 2026 14:07
cf63af5 to
86f5d87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #305.
Even though we only recently made the switch from
ENDFtktoendf_parserpyfor our internal ENDF/PENDF interfacing, taking advantage of OpenMC's NJOY-compatible interpolation functionality pushed me to further investigate usingopenmc.datain general, beyond just the use-case of continuous energy cross-section interpolation withinxs_plotting.My main concern going into this, as I mentioned in the thread under #305, was whether
openmc.datawould be able to parse PENDF files. However, after building these new updates and testing them against the results with the previousendf_parserpydependency, I found them to agree and that concern turned out to be a non-issue. Moreover, a nice add-on benefit that I've found from this migration is that OpenMC's parsing seems to be much faster thanendf_parserpy. Not that it matters so much in the grand scheme of things, because the main contributing factor to the speed of the preprocessor is actually running NJOY itself, but it's still nice to improve the operating speed where it can be done.