Open
Conversation
Owner
|
Hi, could you perhaps provide me an example, or simplified example that can reproduce the problem you're facing? Although I could probably do a better job in error prevention/handling, printing a warning message in a conversion method is a somewhat strange place IMO. I much rather do this before the generation phase starts ,e.g. in the very beginning or during the download process. Btw, about
Maybe this can be explained more clearly in the README.md file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently learned that when using a custom
.jsonfile fornode2nixa missing name is reported as an error. However, if there is also apackage.jsonwith no name, we get the old error.results in
This leads me to believe that the
config.nameundefined error is just not so limited it can be addressed with a single check. This PR adds more logging so that when this error occurs for yet unknown reasons, it's easier to debug.