Skip to content

Comments

Add a second call to patchShebangs to#261

Merged
svanderburg merged 1 commit intosvanderburg:masterfrom
tshaynik:patchshebangs-again
Oct 20, 2021
Merged

Add a second call to patchShebangs to#261
svanderburg merged 1 commit intosvanderburg:masterfrom
tshaynik:patchshebangs-again

Conversation

@tshaynik
Copy link
Contributor

The call to npm rebuild can bring in additional executable scripts
which need to be patched as well.

This relates to issue #184

The call to `npm rebuild` can bring in additional executable scripts
which need to be patched as well.

This relates to issue svanderburg#184
@svanderburg svanderburg merged commit a877d76 into svanderburg:master Oct 20, 2021
@svanderburg
Copy link
Owner

@tshaynik I also ran into a similar problem, but my guess is that the only artifacts that need to be patched are the executable scripts in $out/bin right? I couldn't find any cases so far, in which patching everything is required.

There is also a pull request that specifically patches the binaries only: #266

I'm considering doing this instead, because a double patchshebang over the entire tree makes deployments unnecessary slow.

@tshaynik
Copy link
Contributor Author

tshaynik commented Nov 4, 2021

@tshaynik I also ran into a similar problem, but my guess is that the only artifacts that need to be patched are the executable scripts in $out/bin right? I couldn't find any cases so far, in which patching everything is required.

That makes sense. Patching everything is probably overkill!

There is also a pull request that specifically patches the binaries only: #266

I'm considering doing this instead, because a double patchshebang over the entire tree makes deployments unnecessary slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants