fix: print aliased inline type import specifiers as 'type X as Y'#119
Open
leonidaz wants to merge 1 commit into
Open
fix: print aliased inline type import specifiers as 'type X as Y'#119leonidaz wants to merge 1 commit into
leonidaz wants to merge 1 commit into
Conversation
`ImportSpecifier` with both `importKind: 'type'` and an alias (e.g.
`import { type Foo as Bar } from '...'`) was being printed as
`Foo as type Bar`, which is not valid TypeScript. The `type` keyword now
precedes the imported identifier instead of the local.
🦋 Changeset detectedLatest commit: 480df0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes printing of TS inline-type import specifiers that also have an alias.
Before:
AST:
{ type: 'ImportSpecifier', imported: Foo, local: Bar, importKind: 'type' }Output:
import { Foo as type Bar } from '...'// invalid TSAfter:
Output:
import { type Foo as Bar } from '...'// valid TSThe
typekeyword now precedes the imported identifier rather than the local.Non-aliased cases (
import { type Foo }) are unchanged.Coverage added to test/samples/ts-typed-imports.