Skip to content

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Nov 27, 2024

This PR adds a timeout to ensure the initial scroll has occurred in the browser. It should help with the consistent failures when running the test in vite-ecosystem-ci where the test is too quick and the initial scroll is skipped.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: b8a34ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

await page.goto('/anchor');
await page.evaluate(() => window.scrollTo(0, 1000));
// wait for the scroll to be processed before jumping to the next page
await page.waitForTimeout(1000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a full second here or should we reduce it to 100ms or sth? Also is the same needed after the second scroll? A nicer way could be to await the fact that scrollY is 1000 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you could use page.waitForFunction to avoid a timeout and instead wait for the page position to make it to 1000 pixels?

@benmccann
Copy link
Member

I implemented this directly in #12270 using waitForFunction

@benmccann
Copy link
Member

Thanks! I'm going to close this in favor of #12270 since that PR is green now

@benmccann benmccann closed this Nov 27, 2024
@benmccann benmccann deleted the fix-flaky-scroll branch November 27, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants