fix: use query params for skew protection instead of cookies#14944
fix: use query params for skew protection instead of cookies#14944
Conversation
|
|
While this is promising, I believe there were some questions more generally about whether or not this is the right direction, @Rich-Harris might know more from Vercel-internal discussions |
|
Yeah, I'm also not sure if query params will be sufficient and if it can work in tandem with cookies so that at least the modules loaded in by Vite don't cause a fetch error when they fetch a version that doesn't exist. There are a few more places in Kit I'll have to discover because we construct the import paths manually in some places. Trying to learn from withastro/astro#14543 cc: @serhalp since this may or may not affect how it's implemented for the Netlify adapter. Maybe the concerns Simon is talking about only pertain to Vercel. Vercel's documentation implies that only one method is supported at a time https://vercel.com/docs/skew-protection#supported-frameworks but I think Netlify supports a combination of methods (cookie, query param, header) |
|
This will probably be blocked until the issues surrounding |
closes #12592
WIP. Doing some testing with Vercel deployments using the pkg.pr.new version
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits