-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
breaking: remove stores #15499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
teemingc
wants to merge
51
commits into
version-3
Choose a base branch
from
remove-stores
base: version-3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
breaking: remove stores #15499
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
a830774
resolve todos
teemingc 04e9d02
remove note
teemingc 827d2cf
remove legacy notices
teemingc ea9776c
update
teemingc 0302993
more changesets
teemingc 9d551b7
generate types
teemingc 51c6f4e
format
teemingc 7051187
changeset
teemingc 9e67293
changeset
teemingc 586a565
changeset
teemingc d41d8a4
fix tests
teemingc 86f5469
remove so they error in ts
teemingc 4802e6e
Merge branch 'version-3' into remove-stores
teemingc 5771abf
fix
teemingc 2c94eaf
forgot
teemingc e8a3607
maybe this?
teemingc 874e323
still need one tick
teemingc 14b31eb
fix lint
teemingc 0761306
fix root.svelte
teemingc 0a23144
fix announcer
teemingc c0a09c9
remove unused test
teemingc d6a1968
restore urls
teemingc f137ccd
fix base tests
teemingc c58e850
Merge branch 'main' into remove-stores
teemingc 60b7880
Merge branch 'version-3' into remove-stores
teemingc 204bf2b
comment out deprecate util
teemingc 30b348b
un function
teemingc 091c3d3
fix
teemingc 37757e8
fix test
teemingc 8cd5e90
revert prerendering test app changes
teemingc fedb71a
split into another PR
teemingc a8e16c3
split base removal into separate pr
teemingc 84e3081
Merge branch 'version-3' into remove-stores
teemingc 74b4fed
regenerate types
teemingc 65e9724
split
teemingc 8f789f2
remove references in docs
teemingc 457d75d
revert
teemingc 7a3a7d2
revert
teemingc ff7ae44
split into separate pr
teemingc 26f9ff7
split into separate pr
teemingc 79e6cca
Merge branch 'version-3' into remove-stores
teemingc 096b8b4
split into separate pr
teemingc 49ab52f
split into separate pr
teemingc c969820
split into separate pr
teemingc adbb991
keep async
teemingc c30c850
revert
teemingc cacf9e4
Merge branch 'version-3' into remove-stores
teemingc b9eebe0
Merge branch 'version-3' into remove-stores
teemingc b24e363
split into separate pr
teemingc 4f3ca9c
split
teemingc 20eee63
splittt
teemingc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@sveltejs/kit': major | ||
| --- | ||
|
|
||
| breaking: remove `$app/stores` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a choice of doing
if(untrack(() => mounted))or having this non-reactive flag so that we only announce routes after the first timepageis updated. Seemed cheaper to not importuntrack