breaking: rename command.updates to command.with and query.withOverride to query.override#15571
Open
elliott-with-the-longest-name-on-github wants to merge 5 commits intomainfrom
Open
Conversation
elliott-with-the-longest-name-on-github
changed the title
command.updates to command.with and `query.withO…command.updates to command.with and query.withOverride to query.override
🦋 Changeset detectedLatest commit: f05867e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
elliott-with-the-longest-name-on-github
force-pushed
the
elliott/rename-withoverride-and-updates
branch
from
24ebf18 to
f05867e
Compare
elliott-with-the-longest-name-on-github
force-pushed
the
elliott/rework-overrides
branch
from
b067d98 to
bcf166d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(stacked on #15562)
Since
command.updatesdoesn't actually update anymore, its naming doesn't really make sense. This updates the API:.withaccepts simple() => void"release" callbacks, which makes it somewhat more pluggable than it was before. Additionally,query.overridereturns a simple callback, meaning you can work with overrides yourself if you have cause to.