Draft
Conversation
🦋 Changeset detectedLatest commit: 764b56e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was
linked to
issues
Mar 20, 2026
This was
linked to
issues
Mar 20, 2026
teemingc
commented
Apr 2, 2026
|
|
||
| test.describe.configure({ mode: 'parallel' }); | ||
|
|
||
| test.describe('adapter', () => { |
Member
Author
There was a problem hiding this comment.
These might be better tested in the adapters themselves now that they have a more comprehensive test suite
Member
Author
|
/autofix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements an SSR environment as a
FetchableDevEnvironment. This means that it does not share the same Node process as the Vite host process. This will help ensure that it works with other fetchable dev environments. It also removes theadapter.emulateoption in favour of allowing adapters to provide their own Vite plugins to run customisedconfig,configureServer,configurePreviewServer, andbuildApphooks.Any non-POJO data we were previously passing to the SvelteKit server now has to be communicated via a virtual module or through the HMR API
import.meta.hot. Instances ofssrLoadModulehave also been replaced with the environment module runner.TODOs
- [ ] vite previewFuture PRs
EDIT: I've split the cloudflare changes into a separate PR so that it will be easier to review the changes. Until then,
test-otherswill fail becauseadapter.emulatorhas been removedPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits