Skip to content

fix: recreate nullish deep_set containers#15611

Closed
raashish1601 wants to merge 1 commit intosveltejs:mainfrom
raashish1601:contributor-04/deep-set-nullish-15599
Closed

fix: recreate nullish deep_set containers#15611
raashish1601 wants to merge 1 commit intosveltejs:mainfrom
raashish1601:contributor-04/deep-set-nullish-15599

Conversation

@raashish1601
Copy link
Copy Markdown

closes #15599

Summary

  • recreate intermediate containers when an existing deep_set key is null or undefined
  • keep the invalid array-key guard for non-nullish existing containers
  • add regression coverage for both object and array paths through nullish parents

Testing

  • corepack pnpm lint
  • corepack pnpm check
  • corepack pnpm -F @sveltejs/kit test:unit

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 27, 2026

🦋 Changeset detected

Latest commit: 661b26e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Copy Markdown
Member

We already have #15600 open for this.

@Conduitry Conduitry closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deep_set crashes when setting a nested property on an existing key with value undefined or null

2 participants