fix: prerender no longer silently ignores webpages pertinent to #15620#15621
Open
aenriii wants to merge 7 commits intosveltejs:mainfrom
Open
fix: prerender no longer silently ignores webpages pertinent to #15620#15621aenriii wants to merge 7 commits intosveltejs:mainfrom
aenriii wants to merge 7 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: b2775fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aenriii
added a commit
to Open-Rx/openrx.info
that referenced
this pull request
Apr 1, 2026
Author
|
regressions fixed, should also close #10735 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15620
closes #10735
This PR addresses #15620, and adds tests for any possible regressions as a result of the implemented fix. (edit: seems to also fix #10735)
Changes:
kit/src/core/postbuild/analyse.jsto add additional metadata fields to route metadata,page.prerenderandapi.prerender, which pass on the page and endpoint prerender fields. this prevents a regression which forces all parts of a route to prerender even if only one part requests it.kit/src/core/postbuild/prerender.jsto check ifpage.prerenderandapi.prerenderis true, and enqueue prerendering if so. uses\x00pageas a postfix to page keys within the preexistingseenset to differentiate between api endpoints and pages.kit/src/core/postbuild/prerender.js, added and documentedexpect_htmlparameter invisit()andenqueue()to specify that theAccept: text/htmlheader should be sent to the internal server when prerendering a page.prerendering/basics, one which tests the fix itself (seeprerender-with-server-endpoint) and one which confirms the non-existence of a possible regression (seelinked-api). both tests pass with flying colors :DPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits