Skip to content

fix: avoid inlineDynamicImports ignored with codeSplitting warning when using Vite 8#15647

Open
kiwixz wants to merge 1 commit intosveltejs:mainfrom
kiwixz:vite8_warn
Open

fix: avoid inlineDynamicImports ignored with codeSplitting warning when using Vite 8#15647
kiwixz wants to merge 1 commit intosveltejs:mainfrom
kiwixz:vite8_warn

Conversation

@kiwixz
Copy link
Copy Markdown

@kiwixz kiwixz commented Apr 4, 2026

Closes #15646.

Fixed by not defining inlineDynamicImports when building service worker with Vite 8.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 4, 2026

🦋 Changeset detected

Latest commit: 77549c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like one got missed in #15550

@benmccann benmccann requested review from benmccann and teemingc and removed request for benmccann April 6, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vite 8 warning because of inlineDynamicImports

2 participants