Skip to content

feat: warn on unread validation issues#15653

Open
Rich-Harris wants to merge 1 commit intomainfrom
warn-on-unread-issues
Open

feat: warn on unread validation issues#15653
Rich-Harris wants to merge 1 commit intomainfrom
warn-on-unread-issues

Conversation

@Rich-Harris
Copy link
Copy Markdown
Member

Little quality of life improvement: if you neglect to handle validation issues, SvelteKit will warn at you in dev. If you have a form like this...

export const signup = form(
	v.object({
		user: v.object({
			name: v.literal('Dan', "If your name's not Dan, you're not coming in")
		}),
		password: v.pipe(v.string(), v.minLength(8, 'Password must have at least 8 characters'))
	}),
	(data) => {
		// ...
	}
);

...being used like this...

<form {...signup}>
	<input {...signup.fields.user.name.as('text')} />
	<input {...signup.fields.password.as('password')} />
	<button>sign up</button>
</form>

...then if you don't handle the issues you'll see this:

image

I didn't add a test because testing console logs is annoying and our test suite is already too slow and bloated — adding another one just for this felt like overkill.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 5, 2026

🦋 Changeset detected

Latest commit: 46363d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant