Open
Conversation
🦋 Changeset detectedLatest commit: 60855ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/kit/src/runtime/client/remote-functions/form.svelte.js
Outdated
Show resolved
Hide resolved
packages/kit/src/runtime/client/remote-functions/form.svelte.js
Outdated
Show resolved
Hide resolved
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #14082 (comment):
submit()method (await myform.submit())enhancecallbackPromisewith anupdatesmethod that can be used for optimistic updates{ form, data, submit }object. (It's a copy because we don't want people to just callinstance.submit()inside theenhancecallback, since that would result in preflight validation running twice)To facilitate this I made a small change to the implementation — instead of
enhance(...)returning a fresh object, it just stashes away the callback for later. This is simpler and more consistent with howpreflightworks — it means you can do this, for example, without having to stash away a reference in order to spread it:Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits