Skip to content

Conversation

@Rich-Harris
Copy link
Member

Simpler alternative to #17101. The bug here was that if an effect was scheduled during traversal, causing a follow-up traversal, an effect that was previously deferred would (having been marked CLEAN) incorrectly go into the #maybe_dirty_effects bucket rather than back into the #dirty_effects bucket. The solution is to persist the dirty bucket between runs.

Since block effects run immediately during traversal, they are always made CLEAN immediately, and so should be added to the #dirty_effects bucket straight away rather than being handled in a separate block_effects array — this allows us to simplify the effect target a little bit.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

🦋 Changeset detected

Latest commit: 425937a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@17332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants