Skip to content

fix jekyll 4.0 cache mismatch errors #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix jekyll 4.0 cache mismatch errors #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/jekyll-paginate-v2/generator/paginationPage.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ def initialize(page_to_copy, cur_page_nr, total_pages, index_pageandext)
@base = ''
@url = ''
@name = index_pageandext.nil? ? 'index.html' : index_pageandext
@path = page_to_copy.path

self.process(@name) # Creates the basename and ext member values

Expand Down Expand Up @@ -41,6 +42,8 @@ def initialize(page_to_copy, cur_page_nr, total_pages, index_pageandext)
end

def set_url(url_value)
@path = url_value.delete_prefix '/'
Copy link
Contributor

@ashmaroli ashmaroli Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution: String#delete_prefix was added only in Ruby 2.5. Therefore, this will break on older Ruby versions.

Copy link
Contributor Author

@mohkale mohkale Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this seem better to you?

if path[0] == '/'
  path[1..]
end

@dir = File.dirname(@path)
@url = url_value
end
end # class PaginationPage
Expand Down