refactor(ast_node): Make AST enums non_exhaustive

[quininer]

Description:

This is the split of #11100 . Since we need to add unknown variants to the ast enum, this requires a lot of code changes to handle non-exhaustive match. I'm doing this in a separate PR for review.

BREAKING CHANGE:

Related issue (if exists):

[changeset-bot]

🦋 Changeset detected

Latest commit: da866fd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[kdy1]

Do you think this should go into the main branch?
Can you change the target to ‘dev/rust’?

[quininer]

Sure, I can change it.

[codspeed-hq]

CodSpeed Performance Report

Merging #11115 will not alter performance

_{Comparing quininer:r/ast-non-exhaustive (da866fd) with main (9353763)¹}

Summary

✅ 140 untouched

Footnotes

1. No successful run was found on main (dfe9670) during the generation of this report, so 9353763 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​types/​react-dom@​16.9.25
	@​types/​react@​16.14.67
	copyfiles@​2.4.1
	webpack-cli@​3.3.12
	@​actions/​core@​1.11.1
	webpack-dev-server@​3.11.3
	react-dom@​16.14.0
	@​antfu/​ni@​0.21.12
	webpack@​4.47.0

View full report

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		[email protected] has a Critical CVE. CVE: GHSA-fjxv-7rqg-78g4 form-data uses unsafe random function in form-data for choosing boundary (CRITICAL) Affected versions: < 2.5.4; >= 3.0.0 < 3.0.4; >= 4.0.0 < 4.0.4 Patched version: 2.5.4 From: ? → npm/[email protected] ℹ Read more on: This package | This alert | What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected]. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		[email protected] has Obfuscated code. Confidence: 0.96 Location: Package overview From: ? → npm/[email protected] → npm/[email protected] ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected]. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[Copilot]

Pull Request Overview

This PR implements the first step of adding unknown variants to AST enums by making all AST enums non_exhaustive. The changes enable the introduction of unknown variants in a future PR while ensuring that match statements are properly handled.

• Adds #[cfg(swc_ast_unknown)] conditional branches to handle future unknown variants
• Updates the visitor code generator to conditionally generate fallback arms for swc_ecma_ast
• Makes AST enums non-exhaustive except for specific ones (HTML, XML, regexp) that opt out

Reviewed Changes

Copilot reviewed 185 out of 186 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tools/generate-code/src/main.rs	Updates visitor generator to accept string parameter and detect swc_ecma_ast
tools/generate-code/src/generators/visitor.rs	Conditionally generates fallback arms for unknown variants in match statements
crates//src/.rs	Adds #[cfg(swc_ast_unknown)] fallback branches to existing match statements
crates/*/Cargo.toml	Adds lint configuration to recognize the swc_ast_unknown cfg
crates/swc_*_ast/src/base.rs	Adds no_unknown attribute to specific AST enums that shouldn't be non-exhaustive

Comments suppressed due to low confidence (2)

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[quininer]

I've switched to using a cfg flag instead of a feature to handle unknown variants, which makes it easier to ensure consistent handle.

Also, since all changes are behind the swc_ast_unknown cfg flag, it's not a breaking change. I think it can be safely merged into main branch.

[kdy1]

I updated your branch to use patch commands

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[kdy1]

I added ast_node: major because I don't want to see complains about breaking changes published wrongly

[kdy1]

Thank you! Nice work!