Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolves #1027 #1031

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix: resolves #1027 #1031

merged 2 commits into from
Oct 28, 2024

Conversation

novica
Copy link
Contributor

@novica novica commented Oct 23, 2024

Closes #1027 as discussed in #1027

Copy link

github-actions bot commented Oct 23, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-1031

The following changes were observed in the rendered markdown documents:

 04-changes.md | 4 ++--
 md5sum.txt    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-25 11:46:24 +0000

episodes/04-changes.md Outdated Show resolved Hide resolved
@martinosorb
Copy link
Contributor

Other than the comment above, I'm happy to merge.

Co-authored-by: Martino Sorbaro <[email protected]>
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
@martinosorb
Copy link
Contributor

Thanks!

@martinosorb martinosorb merged commit 186c10e into swcarpentry:main Oct 28, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
Auto-generated via `{sandpaper}`
Source  : 186c10e
Branch  : main
Author  : Martino Sorbaro <[email protected]>
Time    : 2024-10-28 19:22:23 +0000
Message : Merge pull request #1031 from novica/issue-1027

fix: resolves #1027
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
Auto-generated via `{sandpaper}`
Source  : 6e8d8fc
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-28 19:23:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 186c10e
Branch  : main
Author  : Martino Sorbaro <[email protected]>
Time    : 2024-10-28 19:22:23 +0000
Message : Merge pull request #1031 from novica/issue-1027

fix: resolves #1027
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Auto-generated via `{sandpaper}`
Source  : 6e8d8fc
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-28 19:23:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 186c10e
Branch  : main
Author  : Martino Sorbaro <[email protected]>
Time    : 2024-10-28 19:22:23 +0000
Message : Merge pull request #1031 from novica/issue-1027

fix: resolves #1027
github-actions bot pushed a commit to ukceh-rse/git-novice that referenced this pull request Nov 1, 2024
Auto-generated via `{sandpaper}`
Source  : 186c10e
Branch  : main
Author  : Martino Sorbaro <[email protected]>
Time    : 2024-10-28 19:22:23 +0000
Message : Merge pull request swcarpentry#1031 from novica/issue-1027

fix: resolves swcarpentry#1027
github-actions bot pushed a commit to ukceh-rse/git-novice that referenced this pull request Nov 1, 2024
Auto-generated via `{sandpaper}`
Source  : 9fdc0f5
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-01 09:47:13 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 186c10e
Branch  : main
Author  : Martino Sorbaro <[email protected]>
Time    : 2024-10-28 19:22:23 +0000
Message : Merge pull request swcarpentry#1031 from novica/issue-1027

fix: resolves swcarpentry#1027
github-actions bot pushed a commit to ukceh-rse/git-novice that referenced this pull request Nov 5, 2024
Auto-generated via `{sandpaper}`
Source  : 9fdc0f5
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-01 09:47:13 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 186c10e
Branch  : main
Author  : Martino Sorbaro <[email protected]>
Time    : 2024-10-28 19:22:23 +0000
Message : Merge pull request swcarpentry#1031 from novica/issue-1027

fix: resolves swcarpentry#1027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve file creation explanation
2 participants