Skip to content

[core] Fix LocalServer failure to handle large body request (Issue #481) #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2025

Conversation

sebsto
Copy link
Contributor

@sebsto sebsto commented Mar 12, 2025

Fix #481

@sebsto sebsto added kind/bug Feature doesn't work as expected. 🔨 semver/patch No public API change. labels Mar 12, 2025
@sebsto sebsto added this to the 2.0 milestone Mar 12, 2025
@sebsto sebsto requested a review from fabianfett March 12, 2025 22:03
@sebsto sebsto self-assigned this Mar 12, 2025
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix this by adding streaming support here.

@sebsto
Copy link
Contributor Author

sebsto commented Mar 18, 2025

@fabianfett Let's separate concerns. This fix handles the incoming data to the local server (what the client sends us)
Let's open a separate issue and PR to fix the outgoing data, i.e. the streaming response

@sebsto sebsto requested a review from fabianfett March 19, 2025 17:38
@sebsto
Copy link
Contributor Author

sebsto commented Mar 24, 2025

@fabianfett We need to take a decision.
I understand your preference is to revert back to non NIOAsync implementation of the local server.
But while waiting for this, can we merge this one line change that will unblock #481 ?

Then we can plan for a proper revert to v1 implementation.

@Andrea-Scuderi
Copy link
Contributor

Hey @sebsto and @fabianfett,

Thanks for your work on this! I'm really excited to try out the new runtime and have started experimenting with it.

I've run into a bit of a blocker with this particular issue. Do you have a rough idea of when this PR might be merged?

Also, is there any information you can share about the roadmap for the new runtime? Having a bit more insight would be super helpful for planning and building on top of this awesome package.

Thanks again for all your efforts!

Andrea-Scuderi pushed a commit to Andrea-Scuderi/swift-aws-lambda-runtime that referenced this pull request May 31, 2025
@sebsto
Copy link
Contributor Author

sebsto commented May 31, 2025

@Andrea-Scuderi thank you for the encouragement. We’re working on a path to resume development, merge pending PR and tag a 2.0 preview version before the end of the summer

@sebsto sebsto merged commit 7edd4f8 into swift-server:main Jun 1, 2025
32 checks passed
@sebsto
Copy link
Contributor Author

sebsto commented Jun 1, 2025

@fabianfett as this is a blocker for several persons, I decided to move forward by merging this. We can resume the discussion about NIOAsync in a separate issue / PR.

@Andrea-Scuderi heard loud and clear - merged today

@sebsto sebsto deleted the sebsto/fix_481 branch June 1, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Feature doesn't work as expected. 🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Debugging: LambdaHttpServer Drops All But Last Inbound Body Chunk
3 participants