-
Notifications
You must be signed in to change notification settings - Fork 113
[core] Fix LocalServer failure to handle large body request (Issue #481) #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix this by adding streaming support here.
@fabianfett Let's separate concerns. This fix handles the incoming data to the local server (what the client sends us) |
@fabianfett We need to take a decision. Then we can plan for a proper revert to v1 implementation. |
Hey @sebsto and @fabianfett, Thanks for your work on this! I'm really excited to try out the new runtime and have started experimenting with it. I've run into a bit of a blocker with this particular issue. Do you have a rough idea of when this PR might be merged? Also, is there any information you can share about the roadmap for the new runtime? Having a bit more insight would be super helpful for planning and building on top of this awesome package. Thanks again for all your efforts! |
@Andrea-Scuderi thank you for the encouragement. We’re working on a path to resume development, merge pending PR and tag a 2.0 preview version before the end of the summer |
@fabianfett as this is a blocker for several persons, I decided to move forward by merging this. We can resume the discussion about NIOAsync in a separate issue / PR. @Andrea-Scuderi heard loud and clear - merged today |
Fix #481