Add if let to guard and Vice versa transforms #2420
Draft
+1,148
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Jan 5, 2026
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Thanks a lot for implementing this refactoring, @PhantomInTheWire ❤️
The PR is already pretty large, so I’d suggest we focus on the if -> guard refactoring in this PR first and leave guard -> if for a follow-up PR, to simplify review.
I left some first initial comments in the PR. The overall direction seems great and you thought about many edge cases. I’ll do another thorough review once the first set of comments are addressed.
Sources/SwiftLanguageService/CodeActions/ConvertIfLetToGuard.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ConvertIfLetToGuard.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ConvertIfLetToGuard.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ConvertIfLetToGuard.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ConvertIfLetToGuard.swift
Outdated
Show resolved
Hide resolved
PhantomInTheWire
force-pushed
the
feat/guardlet
branch
2 times, most recently
from
5e90594 to
410ce27
Compare
ahoppen
reviewed
Jan 8, 2026
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Started reviewing this again but then realized that you haven’t addressed all my previous comments yet (no problem with that, just didn’t realize before I started reviewing), so stopped half-way.
Sources/SwiftLanguageService/CodeActions/ConvertIfLetToGuard.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ConvertIfLetToGuard.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ConvertIfLetToGuard.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: Karan <[email protected]>
Signed-off-by: Karan <[email protected]>
Signed-off-by: Karan <[email protected]>
…anteesExit Signed-off-by: Karan <[email protected]>
Signed-off-by: Karan <[email protected]>
… doesn't exist Signed-off-by: Karan <[email protected]>
Signed-off-by: Karan <[email protected]>
Signed-off-by: Karan <[email protected]>
Signed-off-by: Karan <[email protected]>
PhantomInTheWire
force-pushed
the
feat/guardlet
branch
from
410ce27 to
3f71cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1569
mostly works but not sure what to do with many edge cases and has a todo for switch statements, also this will probably have conflicts with #2406 marking as draft till that merges and i can resolve the conflicts.
Screen.Recording.2026-01-04.at.17.03.17.mov