Add -z,origin linker flag on OpenBSD. #5196
Conversation
This is required for $ORIGIN rpath processing here (without having to fiddle with workarounds like LD_LIBRARY_PATH).
| @@ -168,6 +168,10 @@ set_target_properties(Foundation PROPERTIES | |||
| INSTALL_RPATH "$ORIGIN" | |||
| INSTALL_REMOVE_ENVIRONMENT_RPATH ON) | |||
|
|
|||
| if(CMAKE_SYSTEM_NAME STREQUAL "OpenBSD") | |||
| target_link_options(Foundation PRIVATE "LINKER:-z,origin") | |||
There was a problem hiding this comment.
All of the targets in the Foundation project (both those here as well as those in swift-foundation) use ORIGIN-based rpath values. Is there something special about the Foundation library, or should this be provided for all of these targets?
There was a problem hiding this comment.
-z origin is a flag that is useful in the odd case that the reference to $ORIGIN does not occur in DT_NEEDED or DT_RUNPATH (DT_RPATH also applies, but that is considered deprecated) and is expected to possibly occur at runtime through libdl (i.e. dlopen). In such cases the computation may be elided as the value is unneeded and could cause a failure otherwise due to the missing value.
There was a problem hiding this comment.
On OpenBSD, -z origin is also required to properly resolve $ORIGIN.
I'm fairly sure this will be required for the other targets, and only the main Foundation library has posed a problem while trying to get the toolchain stood up end to end, so I've only added it for Foundation so far.
It probably is the case I should add them for the other targets, but I need to double-check.
There was a problem hiding this comment.
Ah, right, this is Open, not Free. Open and DragonFly both need -z origin.
This is required for $ORIGIN rpath processing here (without having to fiddle with workarounds like LD_LIBRARY_PATH).