Skip to content

[6.2][Test-Only] Remove a check for compiler side diagnostics #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/6.2
Choose a base branch
from
Open

[6.2][Test-Only] Remove a check for compiler side diagnostics #1884

wants to merge 1 commit into from

Conversation

cachemeifyoucan
Copy link
Contributor

  • Explanation: Remove a check that on the diagnostic message that is on the swift compiler side, that should out of scope of the test.
  • Scope: To enable future cherry-picks of the swift compiler change that update the message.
  • Issues: N/A
  • Original PRs:[Tests] Remove a check for compiler side diagnostics #1882
  • Risk:Low. Test Only change.
  • Testing: N/A
  • Reviewers: @artemcm

@cachemeifyoucan
[Tests] Remove a check for compiler side diagnostics
5d8fd11 
Remove a check for the exact diagnostics message from the compiler
side as it is out of scope for the test and it prohibits improvements
to the diagnostics message from the compiler.

(cherry picked from commit 6635337)
@cachemeifyoucan cachemeifyoucan requested a review from a team as a code owner April 29, 2025 17:28
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cachemeifyoucan