Handle macro expansion args in placeholder expansion#3092
Merged
Conversation
ahoppen
reviewed
Jun 4, 2025
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Looks good to me, just two improvement suggestions on CallLikeSyntax.
Update `ExpandEditorPlaceholdersToLiteralClosures` and `CallToTrailingClosures` such that they can handle macro expansion exprs and decls. This unfortunately requires changing them such that they take a `Syntax` input and output to satisfy the conformance to `SyntaxRefactoringProvider`, but that seems preferable to making the refactoring types themselves generic. If in the future we decide to expose `CallLikeSyntax` as a public protocol, we could decide to expose additional generic `refactor` overloads here. However it's not clear there's enough clients of these APIs to motivate doing that in this PR.
Contributor
Author
|
@swift-ci please test |
bnbarham
approved these changes
Jun 4, 2025
Member
|
@swift-ci Please test Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
ExpandEditorPlaceholdersToLiteralClosuresandCallToTrailingClosuressuch that they can handle macro expansion exprs and decls. This unfortunately requires changing them such that they take aSyntaxinput and output to satisfy the conformance toSyntaxRefactoringProvider, but that seems preferable to making the refactoring types themselves generic.If in the future we decide to expose
CallLikeSyntaxas a public protocol, we could decide to expose additional genericrefactoroverloads here. However it's not clear there's enough clients of these APIs to motivate doing that in this PR.