[6.2][cherrypick] Use -z,nobtcfi when BTCFI is disabled on OpenBSD. #80836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally left off from swiftlang#80389, and will properly ensure BTCFI enforcement is disabled on the platform when required.
DougGregor
approved these changes
Apr 15, 2025
|
@swift-ci please test |
|
@swift-ci please clean test macOS |
1 similar comment
|
@swift-ci please clean test macOS |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
This was accidentally left off from Add a build flavor to opt-out of BTCFI on OpenBSD. #80389, and will properly ensure BTCFI enforcement is disabled on the platform when required.
Add a build flavor to opt-out of BTCFI on OpenBSD. #80389 was merged before the 6.2 cut, so should be picked onto 6.2 to complete the changes.
Scope:
This should be scoped to OpenBSD builds only.
Issues:
See also OpenBSD port tracking #78437 for the master issue tracking OpenBSD.
Original PRs:
Use -z,nobtcfi when BTCFI is disabled on OpenBSD. #80553
Risk:
Risk is minimal, since this is scoped only to OpenBSD.
Testing:
CI has ran on the original prs. OpenBSD nobtcfi-flavored builds require this change.
Reviewers:
@DougGregor