[ClangImporter] Don't import accessors of constants as 'open' if they're static #80940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
xedin,
Xazax-hun,
beccadax,
artemcm and
eeckstein
kubamracek
requested review from
zoecarver,
egorzhdan,
ian-twilightcoder,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
j-hui
approved these changes
Apr 21, 2025
xedin
reviewed
Apr 21, 2025
| @@ -426,7 +426,8 @@ ValueDecl *SwiftDeclSynthesizer::createConstant(Identifier name, | |||
| /*ThrowsLoc=*/SourceLoc(), /*ThrownType=*/TypeLoc(), | |||
| params, type, dc); | |||
| func->setStatic(isStatic); | |||
| func->setAccess(getOverridableAccessLevel(dc)); | |||
| func->setAccess(isStatic ? AccessLevel::Public | |||
| : getOverridableAccessLevel(dc)); | |||
There was a problem hiding this comment.
Hm, I think accessors match the formal access of their storage declaration, so I don't think you need to explicitly set anything here but make sure that var gets the expected access level set.
…QUIRES: objc_interop
|
@swift-ci please test |
…hesizer::createConstant
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
swiftlang/swift-source-compat-suite#1000 |
|
@swift-ci please test Windows platform |
|
@kubamracek looks like cross-testing doesn't work here but the projects are UPASS'ing so feel free to land once Windows CI is green. |
|
@swift-ci please test Windows platform |
Xazax-hun
approved these changes
Apr 22, 2025
Right, this actually says the problem is fixed. |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Windows platform |
|
Retrospective: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup for #80749, which has caused a regression in the Source Compatibility test suite. Concretely, the Alamofire and Kommander projects, see https://ci.swift.org/job/swift-main-source-compat-suite-debug/1090/. The failure is a compiler crash when processing OperationQueue.defaultMaxConcurrentOperationCount (which comes from NSOperationQueueDefaultMaxConcurrentOperationCount constant in a header, with an apinote to put it onto NSOperationQueue/OperationQueue). The crash is:
The error message is pretty clear: The accessor cannot be "open" because it's static. This PR fixes the general
createConstantto avoid creating "open" accessors if they're static.