Skip to content

Clarify _implementationOnly documentation #80960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarify _implementationOnly documentation #80960

wants to merge 1 commit into from
+2 −1

Conversation

raysarebest
Copy link

@raysarebest raysarebest commented Apr 21, 2025 •
edited
Loading

According to SE-0409, an access control modifier should almost always be used instead of @_implementationOnly. This commit adds a reference to that documentation to make it clear to readers of this document

@raysarebest
Clarify _implementationOnly documentation
0c4c153 
According to SE-0409, an access control modifier should almost always be used instead of @_implementationOnly. This commit adds a reference to that documentation to make it clear to readers of this document
compnerd
compnerd reviewed Apr 21, 2025
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this is correct. There are semantics that @_iO covers that ACLs cannot cover outside of ABI stable platforms. As an example, foreign types are leaked even with a private access level but will be encapsulated by @_iO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raysarebest @compnerd