parse symbol availability allow/block-list args together #80968
Merged
+6
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forward-ports a review comment from #80806 back to the main branch.
The way i originally wrote the argument handling for
[-symbol-graph]-{allow,block}-availability-platformsleft in a surprising behavior if both arguments were present, where it would favor the presence of the allowlist argument over the blocklist argument, even if the blocklist was written later in the command-line. This PR updates the argument handling to look for both arguments at the same time and favor whichever is last in the argument list.