[embedded] Make -mergeable-symbols the default for Embedded Swift #80978
+23
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
MaxDesiatov,
phausler,
rauhul,
zoecarver,
eeckstein and
dschaefer2
|
@swift-ci please test |
|
Not sure I love this... |
kubamracek
force-pushed
the
embedded-mergeable-by-default
branch
from
8b72edd to
f1c342e
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have experimented with -mergeable-symbols on some larger projects, and it seems like it does retain dead-stripping as desired, and it seems like the easiest path forward that allows some level of separate compilations (separate .o/.a builds for libraries) in Embedded Swift. Let's make it enabled by default.