Skip to content

[DoNotMerge][6.2][Caching] Reduce the number of cas ID passed on frontend commandline #81493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/6.2
Choose a base branch
from

Conversation

cachemeifyoucan
Copy link
Contributor

  • Explanation: Using IncludeTree::FileList to concat the include tree file systems that are passed on the command-line. This significantly reduce the command-line size, and also makes the cache key computation a lot faster.
  • Scope: Make build log easier to read and also has performance benefits especially for batched builds.
  • Issues: rdar://148752988
  • Original PRs: [Caching] Reduce the number of cas ID passed on frontend commandline #81264
  • Risk: Low. Swift caching only and no functional change intended.
  • Testing: Unit Tests.
  • Reviewers: @benlangmuir

Using IncludeTree::FileList to concat the include tree file systems that
are passed on the command-line. This significantly reduce the
command-line size, and also makes the cache key computation a lot
faster.

rdar://148752988
(cherry picked from commit 201e4fa)
@cachemeifyoucan
Copy link
Contributor Author

Please testing with following PR:
swiftlang/llvm-project#10674

@swift-ci please test

@nkcsgexi
Copy link
Contributor

This is a nice-to-have enhancement. Should we really cherry-pick to release/6.2?

@cachemeifyoucan
Copy link
Contributor Author

This is a nice-to-have enhancement. Should we really cherry-pick to release/6.2?

There are lots of small performance improvements can be enabled after this. I don't expect all the changes will add up to significant amount but followup will not be possible without this. Maybe we can re-evaluate after I land all the changes on main and see the overall improvements and see if we should take all or not.

@nkcsgexi
Copy link
Contributor

Thank you for the additional context, Steven! Yeah, it would be nice to consider what the overall benefits are before we deciding whether to cherry-pick them or not to the release/6.2 branch.

@cachemeifyoucan cachemeifyoucan changed the title [Caching] Reduce the number of cas ID passed on frontend commandline [DoNotMerge][6.2][Caching] Reduce the number of cas ID passed on frontend commandline May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants