Better fixtures#95
Closed
hirasso wants to merge 16 commits into
Closed
Conversation
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Playwright test results
Details
|
✅ Deploy Preview for swup-scroll-plugin ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Closing in favor of #93 as this branch was merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepare fixtures for running tests against.
Preview: https://swup-scroll-plugin.netlify.app/
[data-swup-scroll-container]shouldResetScrollPositionStart the playground:
I based this branch on an intermediate state from the feat/horizontal-scrolling branch. How should we proceed? Should we merge this into
nextand then mergenextinto the feat/horizontal-scrolling branch to finish the work there?CleanShot.2025-06-10.at.21.03.01-small.mp4
Checks
nextbranchnpm run lint)All tests are passing (npm run test)New or updated tests are includedThe documentation was updated as required