Skip to content

[tools/shoestring]: Output node certificate as x509 v3#1422

Open
ccHarvestasya wants to merge 11 commits intosymbol:devfrom
ccHarvestasya:shoestring/node_cert_x509_v3
Open

[tools/shoestring]: Output node certificate as x509 v3#1422
ccHarvestasya wants to merge 11 commits intosymbol:devfrom
ccHarvestasya:shoestring/node_cert_x509_v3

Conversation

@ccHarvestasya
Copy link
Copy Markdown
Contributor

Problem

  • CA certificates are output as x509 v3, but node certificates are output as x509 v1.

Solution.

  • Output node certificate as x509 v3.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.87%. Comparing base (eaffd15) to head (a38afc3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1422      +/-   ##
==========================================
+ Coverage   96.64%   96.87%   +0.23%     
==========================================
  Files         412      261     -151     
  Lines       29296    19124   -10172     
  Branches      695      215     -480     
==========================================
- Hits        28313    18527    -9786     
+ Misses        945      591     -354     
+ Partials       38        6      -32     
Flag Coverage Δ
explorer-rest ?
tools-shoestring 97.07% <100.00%> (+<0.01%) ⬆️
wallet-mobile-symbol ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...oestring/shoestring/internal/CertificateFactory.py 100.00% <100.00%> (ø)

... and 152 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ccHarvestasya and others added 3 commits October 28, 2025 22:32
task: add NemConnector for POST local/chain/blocks-after and local/block/at
task: add Block model
task: add mapping transaction, TransferTransaction, ImportanceTransferTransaction, and ConvertAccountToMultisig
task: refactor the transaction model
task: add new model NamespaceRegistrationTransaction, MosaicDefinitionTransaction, and MosaicSupplyChangeTransaction
task: refactor and support more transactions
task: add new model MultisigTransaction and CosignSignatureTransaction
task: refactor the transaction model and the NEM connector
task: rename transaction model
task: add UnknownTransactionType exception

---
    
Signed-off-by: wayonb <wayon@symbol.dev>
Co-authored-by: Anthony Law <anthony@symbol.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants