[explorer/rest] feat: Added namespace and namespace listing endpoints#2034
Open
AnthonyLaw wants to merge 7 commits intoexplorer/nem-backendfrom
Open
[explorer/rest] feat: Added namespace and namespace listing endpoints#2034AnthonyLaw wants to merge 7 commits intoexplorer/nem-backendfrom
AnthonyLaw wants to merge 7 commits intoexplorer/nem-backendfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## explorer/nem-backend #2034 +/- ##
========================================================
+ Coverage 96.91% 96.93% +0.01%
========================================================
Files 267 269 +2
Lines 19360 19459 +99
Branches 215 215
========================================================
+ Hits 18763 18862 +99
Misses 591 591
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Wayonb
requested changes
Mar 27, 2026
explorer/rest/rest/db/NemDatabase.py
Outdated
| cosignatories=[str(Address(address)) for address in cosignatories] if cosignatories else None | ||
| ) | ||
|
|
||
| def _create_namespace_view(self, result): # pylint: disable=no-self-use |
Contributor
There was a problem hiding this comment.
static method and remove no-self-use
explorer/rest/rest/db/NemDatabase.py
Outdated
| {limit_condition} | ||
| ''' | ||
|
|
||
| def _generate_namespace_query(self, where_condition='', order_condition='', limit_condition=''): # pylint: disable=no-self-use |
Contributor
There was a problem hiding this comment.
same here...make a static method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Missing namespace and namespace listing endpoints in the rest service.
Solution:
/namespace/<name>endpoint for query root or sub namespace/namespacesendpoint query namespace listing.