[Form] Minor #17431
Merged
[Form] Minor #17431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
Nov 12, 2022
| can be rendered as a ``yyyy-MM-dd``-formatted input text box. Internally, a data transformer | ||
| converts the starting ``DateTime`` value of the field into the ``yyyy-MM-dd`` string | ||
| to render the form, and then back into a ``DateTime`` object on submit. | ||
| converts the ``DateTime`` value of the field to the ``yyyy-MM-dd`` string |
Contributor
Author
There was a problem hiding this comment.
Looks like "to" and "into" are both common in general, but Symfony docs seem to prefer "to" usually.
=> @javiereguiluz please decide.
Member
There was a problem hiding this comment.
I asked on Symfony Slack about this to native English speakers. They agreed on using "convert to", but suggested other tweak: dfc2982
Contributor
There was a problem hiding this comment.
"Use “into” to describe where something is: going inside something else" -> Please use to
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing "starting"