[DependencyInjection] Add closure argument type
#17792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
reviewed
Jan 27, 2023
service_container.rst
Outdated
| } | ||
| } | ||
|
|
||
| Now, our configuration would look like this: |
There was a problem hiding this comment.
We can maybe avoid repeat Now, ... which is used just above
There was a problem hiding this comment.
You're right, updated!
alexandre-daubois
force-pushed
the
closure-tag-dic
branch
from
86163ad to
9013293
Compare
alamirault
approved these changes
Jan 28, 2023
javiereguiluz
force-pushed
the
closure-tag-dic
branch
from
9013293 to
3c71f30
Compare
|
Thanks Alex! Yet another superb contribution 🙇 I'm running out of messages to thank you for your amazing contributions 😃 Note: I merged it in 6.2 and up because 6.0 and 6.1 are no longer supported. |
|
Thank you very much Javier! 🙏😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16667