Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mailer] Update mailer.rst #20164

Merged
merged 1 commit into from
Apr 4, 2025
Merged

[Mailer] Update mailer.rst #20164

merged 1 commit into from
Apr 4, 2025

Conversation

GrinWay
Copy link
Contributor

@GrinWay GrinWay commented Aug 25, 2024

This piece of addition information will solve the problem of misunderstanding: Why my emails can't be processed asynchronously.

@smnandre
Copy link
Member

I fear this addition would add some confusion.

In fact, the very next line of the documentation states the opposite:

Note

If your code used Symfony\Component\Mailer\MailerInterface, you need to replace it by Symfony\Component\Mailer\Transport\TransportInterface to have the SentMessage object returned.

So maybe find a better place?

@GrinWay
Copy link
Contributor Author

GrinWay commented Aug 26, 2024

Fixed

@carsonbot carsonbot changed the title Update mailer.rst [Mailer] Update mailer.rst Aug 28, 2024
@javiereguiluz javiereguiluz added this to the 6.4 milestone Apr 4, 2025
@javiereguiluz javiereguiluz changed the base branch from 7.1 to 6.4 April 4, 2025 14:33
@javiereguiluz javiereguiluz merged commit 38f51e1 into symfony:6.4 Apr 4, 2025
2 of 3 checks passed
@javiereguiluz
Copy link
Member

@GrinWay thanks ... and congrats on your first Symfony Docs contribution. Sorry it took us so long to merge it.

While reviewing this, we realized that we had to reword the entire section to explain things more clearly. So, we did that while merging. See 74a146e

Thanks!

@GrinWay GrinWay deleted the patch-2 branch April 4, 2025 17:27
@GrinWay
Copy link
Contributor Author

GrinWay commented Apr 4, 2025

F - Fantastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants