Skip to content

[TwigBundle] Enable #[AsTwigFilter], #[AsTwigFunction] and #[AsTwigTest] #20879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 7.3
Choose a base branch
from

Conversation

RisingSunLight42
Copy link
Contributor

@RisingSunLight42 RisingSunLight42 commented Apr 12, 2025

fix #20828

I did not listed the AsTwigTest attribute in the attributes list as no doc make mention of use case of this attribute. Do I had it anyway without any link to it (or a link to the twig documentation)?

Also I hope my wording is correct, feel free to ask me any adjustment 😄

I followed the plan of @javiereguiluz

@carsonbot carsonbot added this to the 7.3 milestone Apr 12, 2025
@RisingSunLight42
Copy link
Contributor Author

I have no clue why the CI fails to build the docs, I can build it properly on my end 😞

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few comments. I find it hard to juggle the old and new ways of doing things in the same doc without making it too complex to understand; but it looks fine to me the way it is.

@RisingSunLight42
Copy link
Contributor Author

Thanks for the comment GromNan, it's very appreciated especially since I'm still new to the doc repository. I'm slowly starting to get the hang of how to write it 🎉. I'll apply your suggestions tomorrow 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TwigBundle] Enable #[AsTwigFilter], #[AsTwigFunction] and `#[AsTwi…
4 participants