Skip to content

[RFC] chore: use assert instead of phpdoc #20888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 7.2
Choose a base branch
from

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Apr 15, 2025

hello
RFC on such change: with a codebase and langage being more and more type hinted and less with phpdoc
and with ppl copying/getting inspired with the official doc
wdyt of such changes? keep it or trash it ? can we replicate elsewhere?

thank you

@javiereguiluz
Copy link
Member

My opinion about adding assert() calls in docs is 👎

I think it's a bit confusing for many newcomers and it's not a widespread practice for other developers, in my own experience.

But let's wait for more opinions about this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants