[Autocomplete] Escape querySelector option value #2620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This to correctly find values like "["test"]".
Kocal
requested changes
Mar 3, 2025
There was a problem hiding this comment.
I'm not sure to understand your changes, can you give us more context please?
Also, you need to build the assets since you modified the assets source code, please read https://github.com/symfony/ux/blob/2.x/CONTRIBUTING.md#working-with-assets
carsonbot
added
Status: Needs Work
Kocal
changed the title
Kocal
changed the title
|
Hi Kocal, Thanks for your comments. I'll try building the assets. But I can't reproduce my issue of yesterday... |
|
Hi, alright, let me know if you need help! |
|
Some info about the error message: |
carsonbot
added
Status: Needs Review
….querySelector: ':scope > option[value=[foo]]' is not a valid selector
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This to correctly find values like "["test"]".