[Autocomplete] Escape querySelector option value #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This to correctly find values like "["test"]".
….querySelector: ':scope > option[value=[foo]]' is not a valid selector
carsonbot
added
Autocomplete
Bug
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||
|
Should I worry about the 3 failed checks? |
smnandre
reviewed
Mar 30, 2025
| @@ -325,6 +325,10 @@ export default class extends Controller { | |||
| return string.replace(/(<([^>]+)>)/gi, ''); | |||
| } | |||
|
|
|||
| #addSlashes(string: string): string { | |||
There was a problem hiding this comment.
I recently learned the existence of CSS.escape() Would it not be better than a custom implementation here ?
smnandre
reviewed
Mar 30, 2025
| @@ -192,7 +192,7 @@ export default class extends Controller { | |||
| for (const [, tomSelectOption] of Object.entries(this.tomSelect.options)) { | |||
| if (tomSelectOption.$order === optionOrder) { | |||
| orderedOption = parentElement.querySelector( | |||
| `:scope > option[value="${tomSelectOption[this.tomSelect.settings.valueField]}"]` | |||
| `:scope > option[value="${[this.#addSlashes(this.tomSelect.settings.valueField)]}"]` | |||
There was a problem hiding this comment.
Are we sure here ? What is the goal of providing an array ?
Hello @Bartheyrman22 ... do you have a simple reproducer we can test to see what happens here ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly escape the querySelector for option-values like "["Test"]"/
This to mitigate:
Some remark where I don't have a solution for:
The issue is only reproduceable on Chrome.
In Firefox, the code in the controller.js is not executed properly. So the error get's never triggered.
But no side effects detected so far.