[WIP] LiveUrl #2673
Draft
[WIP] LiveUrl #2673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
||||||||||||||||||
|
(Had a quick chat with @mbuliard yesterday — he's making a few adjustments before opening the PR. Stay tuned! 😄 ) |
mbuliard
force-pushed
the
live-url
branch
3 times, most recently
from
f94cfd2 to
c1b1f43
Compare
smnandre
reviewed
Apr 10, 2025
| @@ -328,6 +329,10 @@ export default class Component { | |||
| } | |||
|
|
|||
| this.processRerender(html, backendResponse); | |||
| const liveUrl = await backendResponse.getLiveUrl(); | |||
| if (liveUrl) { | |||
| HistoryStrategy.replace(new UrlUtils(liveUrl + window.location.hash, window.location.origin)); | |||
There was a problem hiding this comment.
Suggested change
| HistoryStrategy.replace(new UrlUtils(liveUrl + window.location.hash, window.location.origin)); | |
| history.replaceState(history.state, '', liveUrl + window.location.hash); |
? (not sure)
There was a problem hiding this comment.
This would allow the remove both queryStringPlugin.ts and url_utils.ts (i think)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, do not merge