[CalendarLink] Add component#3460
Conversation
b7c7159 to
4da188d
Compare
|
Hi, Symfony UX 3.0 has been released, and the Could you please retarget this PR to the Thanks! |
bb5ab31 to
13a1fc5
Compare
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Kocal
left a comment
There was a problem hiding this comment.
Thanks for working on this component!
Please ensure to read the whole review before starting anything, my mind changed during the review and I'm sure we don't need a dedicated route (and everything related) for downloading a .ics file.
Thanks you!
405061c to
8348232
Compare
I did a large cleanup here and the CI is green. |
74889b4 to
c83ae65
Compare
c83ae65 to
3920086
Compare
Kocal
left a comment
There was a problem hiding this comment.
Thanks for taking care about my previous comments, here some new ones.
Overall it looks fine, but I still want to take some time to try it inside a real project.
Thanks!
2e7cc5d to
3078044
Compare
Kocal
left a comment
There was a problem hiding this comment.
LGTM, with some comments in tests.
I will try to take some time ASAP to test it
| $uuid = Uuid::fromString('0192a5d2-7c6f-7000-8000-000000000000'); | ||
| $factory = $this->createStub(UuidFactory::class); | ||
| $factory->method('create')->willReturn($uuid); | ||
|
|
||
| $this->builder = new IcsBuilder($factory); |
There was a problem hiding this comment.
This is wrong, the whole point for using Symfony UID and the UuidFactory is to use the MockUuidFactory in tests.
If I'm not wrong, it should be something like that
| $uuid = Uuid::fromString('0192a5d2-7c6f-7000-8000-000000000000'); | |
| $factory = $this->createStub(UuidFactory::class); | |
| $factory->method('create')->willReturn($uuid); | |
| $this->builder = new IcsBuilder($factory); | |
| $this->builder = new IcsBuilder(new MockUuidFactory([ | |
| Uuid::fromString('0192a5d2-7c6f-7000-8000-000000000000') | |
| ])); |
| protected function tearDown(): void | ||
| { | ||
| $this->kernel->shutdown(); | ||
| } |
There was a problem hiding this comment.
I think it can be replaced by:
| } | |
| final class BundleIntegrationTest extends KernelTestCase | |
| { | |
| protected static function getKernelClass(): string | |
| { | |
| return TestKernel::class; | |
| } |
or even this, since KERNEL_CLASS is already configured in the PHPUnit config file:
| } | |
| final class BundleIntegrationTest extends KernelTestCase | |
| { |
This new component address the #3308 idea , it provide twig functions as proposed by (@Kocal) with an easy way to configure calendar links , it supports Google Calendar, Microsoft Outlook and Ics.
I did not include a dropdown in the component since we can use any other dropdown from any Kit or custom Dropdown.