[Toolkit][Shadcn] Add menubar recipe#3486
Open
Amoifr wants to merge 5 commits intosymfony:3.xfrom
Open
Conversation
This was referenced Apr 18, 2026
Contributor
Author
|
Main example Capture.video.du.2026-04-19.19-20-55.mp4 |
Contributor
Author
|
Checkbox example (better than original) Capture.video.du.2026-04-19.19-24-46.mp4 |
Contributor
Author
|
Radio example (better than original) Capture.video.du.2026-04-19.19-39-30.mp4 |
Contributor
Author
|
Submenu example : Capture.video.du.2026-04-19.19-41-19.mp4 |
Contributor
Author
|
With icons : Capture.video.du.2026-04-19.19-43-56.mp4 |
Contributor
Author
|
RTL example Capture.video.du.2026-04-19.19-49-43.mp4 |
Amoifr
force-pushed
the
feat/toolkit-shadcn-menubar
branch
from
d89e1c0 to
4185895
Compare
carsonbot
added
Feature
Follow up on the review feedback on symfony#3487: the Trigger and SubTrigger templates should not enforce a specific HTML element but expose a Twig variable with the needed attributes so the consumer can pick their own element.
Amoifr
force-pushed
the
feat/toolkit-shadcn-menubar
branch
from
1ebf71c to
76bcd84
Compare
Apply the same hover/focus pattern as hover-card and navigation-menu. The previous CSS-only approach (group-hover + group-focus-within + tabindex=0 on submenu) left submenus stuck open after a click. Add a shared menubar_controller.js toggling data-state, wire mouseenter/ mouseleave on Menu and Sub, focus/blur on Trigger and SubTrigger, and switch Content + SubContent to in-data-[state=open] selectors.
Amoifr
force-pushed
the
feat/toolkit-shadcn-menubar
branch
from
76bcd84 to
ff6220a
Compare
Contributor
Author
|
Hi @Kocal! Just pushed an update aligning this recipe with the patterns we've validated on the other Shadcn components shipped recently (notably hover-card #3478 merged earlier today). The original implementation relied on the pure-CSS The fix follows the same approach as hover-card and navigation-menu, with one menubar-specific twist:
Companion PR for ux.symfony.com is updated too: symfony/ux.symfony.com#69. No rush at all, just letting you know it's ready for another look! 🙏 |
Avoid duplicating the radio group `name` on each `Menubar:RadioItem`. The parent `Menubar:RadioGroup` now exposes its `name` to its direct children through a Twig variable; `RadioItem` falls back to it when its own `name` is omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
menubarrecipe to the Shadcn kit.Part of the split of #3468 into one PR per component, tracking #3233.
Snapshots will be regenerated after rework.