[LiveComponent] Re-emit render hooks as live:render:* DOM events#3504
Open
haraldpdl wants to merge 1 commit intosymfony:3.xfrom
Open
[LiveComponent] Re-emit render hooks as live:render:* DOM events#3504haraldpdl wants to merge 1 commit intosymfony:3.xfrom
haraldpdl wants to merge 1 commit intosymfony:3.xfrom
Conversation
Contributor
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||
ce23580 to
f79ab7e
Compare
f79ab7e to
5503ac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-emits the existing
render:startedandrender:finishedJS hooks as bubbling DOM events on the component's root element, alongside the already-publiclive:connect/live:disconnect. Purely additive, no BC concern.The motivation is the longstanding pain in #1038 / #1676 (both closed by stale-bot, neither resolved): third-party Stimulus controllers that need to react to a render have to import
getComponent, await it insideinitialize(), and register against the JS hook API, which is racey on first mount and only fires for re-renders. Falling back to aMutationObserverworks but observes every DOM change rather than render boundaries. A bubbling DOM event lets any code subscribe with a singleaddEventListener, no async setup, no race.Implementation re-uses the existing
dispatchEventhelper that already powerslive:connect/live:disconnect. Test intest/unit/controller/render.test.ts, doc section under "JavaScript Component Hooks > DOM Events", CHANGELOG entry under 3.1.