Skip to content

Fix Twig deprecations in TokenParser #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobvandevijver merged 1 commit into from
Feb 25, 2025
Merged

Fix Twig deprecations in TokenParser #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Twig/TokenParser/ExtendsAdmingeneratedTokenParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Admingenerator\GeneratorBundle\Twig\TokenParser;

use Twig\Error\SyntaxError;
use Twig\Node\EmptyNode;
use Twig\Node\Expression\ConstantExpression;
use Twig\Node\Node;
use Twig\Token;
Expand All @@ -13,10 +14,6 @@ class ExtendsAdmingeneratedTokenParser extends AbstractTokenParser

public function parse(Token $token): ?Node
{
if (null !== $this->parser->getParent()) {
throw new SyntaxError('Multiple extends tags are forbidden', $token->getLine());
}

$templateParts = explode(':', $this->parser->getCurrentToken()->getValue()); //AcmeBundle:namespace:template.html.twig
if (count($templateParts) !== 3) {
list($bundle, $folder, $file) = explode('/', $this->parser->getCurrentToken()->getValue()); //@Acme/namespace/template.html.twig
Expand All @@ -32,7 +29,7 @@ public function parse(Token $token): ?Node
$this->parser->setParent(new ConstantExpression($path,$token->getLine()));
$this->parser->getStream()->expect(Token::BLOCK_END_TYPE);

return null;
return new EmptyNode($token->getLine());
}

public function getTag(): string
Expand Down