-
Notifications
You must be signed in to change notification settings - Fork 455
Fix text alignment in welcome slides (fixes #1625) #1656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if it's straight forward, a screenshot would be appreciated.
And commit message/PR title by convention is "comment (fixes #no)", e.g. "Right align welcome screen text (fixes #1625)" here.
Right align welcome screen text (fixes syncthing#1625)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my point of view, but I'm also missing a screenshot from @offgridauthor . Anyway, thank you very much for your contribution.
🤖 beep boop I'm going to close this pull request as it has been idle for more than 90 days. This is not a rejection, merely a removal from the list of active pull requests that is periodically reviewed by humans. The pull request can be reopened when there is new activity, and merged once any remaining issues are resolved. |
Sorry. We clearly overslept on this. The merge conflicts should be resolved and we should just merge it. |
Don't think so: On phone cant check, but I think the other PR fixed it too and there was something unclear to me when i reviewed, that's why I wanted (and if still relevant want) screenshots. |
Actually, you are right, back at PC, this seems fixed, hence closing. |
resolved #1625 changed text alignment from centered to left on three welcome slides