Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Fix text alignment in welcome slides (fixes #1625) #1656

Closed
wants to merge 6 commits into from

Conversation

offgridauthor
Copy link

resolved #1625 changed text alignment from centered to left on three welcome slides

Copy link
Member

@imsodin imsodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it's straight forward, a screenshot would be appreciated.

And commit message/PR title by convention is "comment (fixes #no)", e.g. "Right align welcome screen text (fixes #1625)" here.

@Catfriend1 Catfriend1 changed the title Resolved Issue #1625 for text alignment activity_firststart slides Fix text alignment in welcome slides (fixes #1625) Aug 20, 2021
@Catfriend1 Catfriend1 added this to the v1.18.2 milestone Aug 20, 2021
@Catfriend1 Catfriend1 added the UI label Aug 20, 2021
Copy link
Contributor

@Catfriend1 Catfriend1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my point of view, but I'm also missing a screenshot from @offgridauthor . Anyway, thank you very much for your contribution.

@st-review
Copy link

🤖 beep boop

I'm going to close this pull request as it has been idle for more than 90 days.

This is not a rejection, merely a removal from the list of active pull requests that is periodically reviewed by humans. The pull request can be reopened when there is new activity, and merged once any remaining issues are resolved.

@AudriusButkevicius
Copy link
Member

Sorry. We clearly overslept on this. The merge conflicts should be resolved and we should just merge it.

@imsodin
Copy link
Member

imsodin commented Dec 6, 2021

Don't think so: On phone cant check, but I think the other PR fixed it too and there was something unclear to me when i reviewed, that's why I wanted (and if still relevant want) screenshots.

@AudriusButkevicius
Copy link
Member

AudriusButkevicius commented Dec 6, 2021

Actually, you are right, back at PC, this seems fixed, hence closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome wizard: Text should be left- or right-aligned, not centered
5 participants