Skip to content

add EVL301 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add EVL301 #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8dc182
add EVL301
syngan Apr 24, 2016
73e89fd
fix EVL301
syngan Apr 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions autoload/vimlint.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ let s:default_errlevel.EVL204 = s:DEF_NON
let s:default_errlevel.EVL205 = s:DEF_WRN
let s:default_errlevel.EVL206 = s:DEF_NON
let s:default_errlevel.EVL207 = s:DEF_NON
let s:default_errlevel.EVL301 = s:DEF_WRN
let s:default_errlevel.EVL901 = s:DEF_WRN
let s:default_errlevel.EVL902 = s:DEF_WRN
let s:def_var_name = ':'
Expand Down Expand Up @@ -130,7 +131,7 @@ function! s:extend_errlevel(param) abort " {{{
for key in keys(s:default_errlevel)
" echo "param[" . key . "]"
if !has_key(param, key)
call s:set_param(param, key, s:DEF_ERR, s:def_var_name)
call s:set_param(param, key, key[3] == '3' ? s:DEF_WRN : s:DEF_ERR, s:def_var_name)
elseif type(param[key]) == type(0)
call s:set_param(param, key, param[key], s:def_var_name)
elseif type(param[key]) != type({})
Expand Down Expand Up @@ -657,7 +658,7 @@ function! s:reconstruct_varstack_rt(self, env, pos, brk_cont, nop) abort " {{{
if v.type ==# 'append' && v.v.ref == 0 && a:env.global.fins == 0
" 変数を追加したが参照していない
" かつ, finally 句がない場合
call a:self.error_mes(v.node, 'EVL102', 'unused variable2 `' . v.var. '`', v.var)
call a:self.error_mes(v.node, 'EVL102', 'unused variable2 `' . v.var . '`', v.var)
endif
let a:env.varstack[j] = nop
endfor
Expand Down Expand Up @@ -1670,7 +1671,15 @@ function s:VimlLint.compile_subtract(node, ...) abort
endfunction

function s:VimlLint.compile_concat(node, ...) abort
return self.compile_op2(a:node, '.')
let r = self.compile_op2(a:node, '.')
" google style guide. use spaces around operators
let line = self.lines[r.pos.lnum - 1]
if line[r.pos.col - 2] !~# '\s' || len(line) > r.pos.col && line[r.pos.col] !~# '\s'
if self.filename !=# ''
call self.error_mes(r, 'EVL301', 'use space around operator `.`', r)
endif
endif
return r
endfunction

function s:VimlLint.compile_multiply(node, ...) abort
Expand Down Expand Up @@ -1736,6 +1745,7 @@ function s:VimlLint.parse_string(str, node, cmd, ref) abort "{{{
" @TODO 今は変数の中身は参照していないので適当に代入可能
endif
let r = s:vlp.StringReader.new(lines)
let c.lines = lines
call c.compile(p.parse(r), 1)
catch
call self.error_mes(a:node, 'EVL203', 'parse error in `' . a:cmd . '`', 1)
Expand Down Expand Up @@ -1948,9 +1958,12 @@ function! s:vimlint_file(filename, param, progress) abort " {{{
if a:param.type ==# 'string'
let r = s:vlp.StringReader.new(vimfile)
let c.filename = ''
let c.lines = split(vimfile, "\n")
else
let r = s:vlp.StringReader.new(readfile(vimfile))
let l = readfile(vimfile)
let r = s:vlp.StringReader.new(l)
let c.filename = vimfile
let c.lines = l
endif


Expand Down
5 changes: 5 additions & 0 deletions doc/vimlint.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,11 @@ EVL206: `v` can be used for `x` *EVL206*

EVL207: statement with no effect *EVL207*


style
EVL301: use space around operator `x` EVL301


system error
EVL901: unknown type `t` *EVL901*
EVL902: assert error `t` *EVL902*
Expand Down