Draft
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Member
Author
|
Android launchers don't reliably support night-qualified resources for icon backgrounds |
Member
Author
|
Drafted because the icon wasn't changing when switching between dark/light modes. Tested on emulator, will test on physical device |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds dark mode support for the app icon, displaying a black background when the device is in dark mode instead of the default orange.
Description
launcher_bgcolor resource that resolves to orange (#FF4400) in light mode and black (#000000) in dark modelauncher_bgcolor instead of hardcodedbrandcolorPreview
dark.webm
QA Notes