-
Notifications
You must be signed in to change notification settings - Fork 1
fix: add retry logic for channel monitor retrieval during migration #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
|
Is it intentional that we continue with restoring if one or more channel monitors fail to retrieve? Seems to me like we should only restore if everything goes right, and if not show the restore error. |
I thought that if an error happens for some reason that we don't know yet, other than just connection, the user could be stuck outside the wallet On the case that we got from support, the wallet migrate almost all the channels except one, that was force closed But I agree, the restore error is also a valid solution, since the user could also try to restore from mnemonics if they are backed up |
pwltr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, comments above not applicable to this PR.
Indeed, that is what happened. I found it was a force close from the logs |
|
Waiting for the migration tests to succeed https://github.com/synonymdev/bitkit-ios/actions/runs/21628335768 |

Description
This PR fixes a critical bug where channel monitor retrieval failures during migration from the React Native app were silently dropped, potentially causing permanent loss of Lightning channel state.
retrieveChannelMonitorWithRetrymethod with configurable retry attempts and linear backoffThis is the iOS equivalent of the Android fix: synonymdev/bitkit-android#760
Linked Issues/Tasks
Related: synonymdev/bitkit-android#760
Screenshot / Video
N/A - internal migration logic fix