Skip to content

Update tsconfig.json #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 29, 2023
Merged

Update tsconfig.json #7

merged 8 commits into from
Jan 29, 2023

Conversation

jameshfisher
Copy link
Contributor

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Fix issue described in #6

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 26, 2023
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jameshfisher!
node16 module resolution is something making its way through the ecosystem, but hasn't reached here yet.
Thanks for looking into it.

A couple items to get it across the finish line.

  1. Could you update the ts config of this project to use node16 resolution (using the same config options elsewhere https://github.com/syntax-tree/mdast-util-assert/blob/8958dff406cb658abc4189568ed7af2c56d9320c/tsconfig.json)
  2. Could you look into the type error currently breaking CI? (which may require going to some of this project's dependencies and updating them to support node16 mode as well)

@wooorm
Copy link
Member

wooorm commented Jan 27, 2023

Yup, you should be able to port this commit: syntax-tree/mdast-util-assert@8958dff. And things will work :)

@jameshfisher
Copy link
Contributor Author

@wooorm I've ported that commit, updated some dependencies, and tried to resolve some broken references in imports. It still has lots of type-checking errors though, and I don't know how to resolve them.

(It doesn't help that my laptop explodes and takes 15+ seconds for types to update when making any single-character changes in VS Code. This seems to be associated with instances of visit causing some perverse worst-case in type-checking. Any advice on this weird problem appreciated!)

Copy link
Member

@remcohaszing remcohaszing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just 2 small suggestions

@wooorm wooorm changed the title Make typechecking work with "moduleResolution": "node16" (Fixes #6) Update tsconfig.json Jan 29, 2023
@wooorm wooorm merged commit 0d4fd9f into syntax-tree:main Jan 29, 2023
@github-actions

This comment has been minimized.

@wooorm wooorm added ☂️ area/types This affects typings 💪 phase/solved Post is done labels Jan 29, 2023
@wooorm
Copy link
Member

wooorm commented Jan 29, 2023

Thanks!

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 29, 2023
@jameshfisher jameshfisher deleted the patch-1 branch January 29, 2023 18:11
@wooorm
Copy link
Member

wooorm commented Jan 30, 2023

Released in 2.2.3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

4 participants