Add CI that runs things through valgrind.#152
Open
luciansmith wants to merge 14 commits into
Open
Conversation
Also compile that with debug info, so any error message will be at least somewhat informative. Also allow manual running of valgrind on the debug branch when we need more diagnostic information.
Also upload all of them as an artifact, and split into groups of 20 so we see them before waiting the entire time.
We were inconsistently deleting a passed-around vector<string>* object from antimony.ypp. Now we pass it as a const reference instead, and delete it inside antimony.ypp directly, instead of inside the functions it passed to. Also actually delete the removed rateOf function definition when it was found in the SBML model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.